Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199615305
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c ---
@@ -128,6 +114,12 @@ static void
guac_rdpdr_device_fs_iorequest_handler(guac_rdpdr_device* device,
}
static void guac_rdpdr_device_fs_free_handler(guac_rdpdr_device* device) {
+
+ free(device->rdpdr);
+ free((char *) device->device_name);
+ free(device->dos_name);
--- End diff --
Both `device->device_name` and `device->dos_name` currently point to static
strings (assigned within `guac_rdpdr_register_fs()`) which should not be passed
to `free()`.
---
