Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199625009
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c ---
@@ -128,6 +114,12 @@ static void
guac_rdpdr_device_fs_iorequest_handler(guac_rdpdr_device* device,
}
static void guac_rdpdr_device_fs_free_handler(guac_rdpdr_device* device) {
+
+ free(device->rdpdr);
+ free((char *) device->device_name);
+ free(device->dos_name);
+ Stream_Free(device->device_announce, 1);
--- End diff --
I think this is already present:
https://github.com/apache/guacamole-server/blob/67680bd2d51e7949453f0f7ffc7f4234a1136715/src/protocols/rdp/compat/winpr-stream.h#L68
and:
https://github.com/apache/guacamole-server/blob/67680bd2d51e7949453f0f7ffc7f4234a1136715/src/protocols/rdp/compat/winpr-stream.c#L38
And it looks like the defined `Stream_Free()` function takes two arguments??
---
