Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/guacamole-server/pull/154#discussion_r199615001
  
    --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_fs_service.c ---
    @@ -128,6 +114,12 @@ static void 
guac_rdpdr_device_fs_iorequest_handler(guac_rdpdr_device* device,
     }
     
     static void guac_rdpdr_device_fs_free_handler(guac_rdpdr_device* device) {
    +
    +    free(device->rdpdr);
    --- End diff --
    
    The `guac_rdpdrPlugin` pointed to by each `device->rdpdr` is a single, 
common shared instance. It is allocated externally and ultimately freed when 
the RDPDR plugin is unloaded:
    
    
https://github.com/apache/guacamole-server/blob/67680bd2d51e7949453f0f7ffc7f4234a1136715/src/protocols/rdp/guac_rdpdr/rdpdr_service.c#L122


---

Reply via email to