Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/154#discussion_r199628303
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -165,9 +165,6 @@ static void
guac_rdpdr_device_printer_iorequest_handler(guac_rdpdr_device* devic
static void guac_rdpdr_device_printer_free_handler(guac_rdpdr_device*
device) {
- free(device->rdpdr);
- free((char *) device->device_name);
--- End diff --
`device->device_name` *is* dynamically allocated in this case (printer) due
to the changes in this PR. Only the filesystem one currently remains static and
shouldn't be freed.
---
