Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/206#discussion_r238168882
--- Diff: src/guacd/daemon.c ---
@@ -275,6 +281,17 @@ int main(int argc, char* argv[]) {
/* General */
int retval;
+#ifdef PTHREAD_STACK_SIZE
+ /* Set default stack size */
+ pthread_attr_t default_pthread_attr;
+ if (pthread_attr_init(&default_pthread_attr) ||
+ pthread_attr_setstacksize(&default_pthread_attr,
PTHREAD_STACK_SIZE) ||
+ pthread_setattr_default_np(&default_pthread_attr)) {
+ fprintf(stderr, "Couldn't set requested pthread stack size of
%d\n", PTHREAD_STACK_SIZE);
--- End diff --
> `"Couldn't set requested pthread stack size of %d\n"`
At the time this failure occurs, the user hasn't requested anything - the
stack size is set permanently at build time. This message should be rephrased
such that the nature of the error can be understood by the user running guacd.
---
