Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/206#discussion_r238170624
--- Diff: src/guacd/daemon.c ---
@@ -19,6 +19,12 @@
#include "config.h"
+#ifdef PTHREAD_STACK_SIZE
+#define _GNU_SOURCE 1
--- End diff --
I'm concerned over explicitly setting `_GNU_SOURCE` and using the
non-portable `pthread_setattr_default_np()`. There's no guarantee that
`pthread_setattr_default_np()` will be available, or that it will be available
if `_GNU_SOURCE` is set.
Testing for these within configure would be an improvement, but the
non-portability is still concerning. Is there no portable way to do this?
---
