GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-client/pull/345
GUACAMOLE-234: Migrate to Apache Directory API for LDAP Extension
This change request takes a new stab at migrating from the legacy Novell
JLDAP API to the Apache Directory API for LDAP access. I've tried to make sure
we're using as much of the API as possible for parsing and verification and
eliminated overlapping functionality. I'm sure there are some more
optimizations that could be done, but this pretty well takes care of things for
now, I think.
I have tested it against ActiveDirectory and it seems to work fine, but
it'd be nice if others could test it against other directories.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/necouchman/guacamole-client jira/234
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-client/pull/345.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #345
----
commit 6643923a61fbd97866d889eea78194e090c0a374
Author: Nick Couchman <vnick@...>
Date: 2018-12-09T13:32:16Z
GUACAMOLE-234: Convert LDAP extension to use Apache Directory LDAP API.
commit 37022bb552e60631033f3630bc0a0545f9c6f1d7
Author: Nick Couchman <vnick@...>
Date: 2018-12-09T14:48:01Z
GUACAMOLE-234: Clean up some LDAP implementation details.
commit 2abd46b0e130548fe1219de7d6369b724c80fa55
Author: Nick Couchman <vnick@...>
Date: 2018-12-09T15:42:12Z
GUACAMOLE-234: Clean up comments.
commit 197f5fe7997cc1f8a636e9c114e2dd967b8ae4a1
Author: Nick Couchman <vnick@...>
Date: 2018-12-09T15:55:39Z
GUACAMOLE-234: Exclude slf4j from Apache Directory dependency.
----
---
