Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/345#discussion_r241905520
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
---
@@ -240,17 +244,24 @@ public LDAPAuthenticatedUser
authenticateUser(Credentials credentials)
try {
+ LdapConnectionConfig ldapConnectionConfig =
+ ((LdapNetworkConnection) ldapConnection).getConfig();
+ Dn authDn = new Dn(ldapConnectionConfig.getName());
--- End diff --
Is there a better way of retrieving the `Dn` than reparsing it from a
string? Perhaps it could be stored somewhere by the relevant `bindAs()`
implementation? Or perhaps we should be using our own object that provides
access to both the `LdapConnection` and the bind `Dn`?
---
