Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/345#discussion_r241902907
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java
---
@@ -240,17 +244,24 @@ public LDAPAuthenticatedUser
authenticateUser(Credentials credentials)
try {
+ LdapConnectionConfig ldapConnectionConfig =
+ ((LdapNetworkConnection) ldapConnection).getConfig();
--- End diff --
Is this typecast necessary? If `bindAs()` will always return an
`LdapNetworkConnection` and we need to use that object as an
`LdapNetworkConnection`, then `bindAs()` should be declared as such.
... This may not be relevant depending on the answer to the comment
regarding `new Dn(ldapConnectionConfig.getName())`, though.
---
