Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245744066
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java
---
@@ -167,18 +201,34 @@
// Parse name
String name = parameter.substring(0, equals);
String value = parameter.substring(equals+1);
-
- config.setParameter(name, value);
+
+ // Pull out and set proxy parameters, if
present
+ // Otherwise set the parameter.
+ switch(name) {
+ case PROXY_HOST_PARAMETER:
--- End diff --
These should probably be separate, dedicated LDAP attributes, rather than
reusing `guacConfigParameter` (which is meant for connection parameters). This
would mean changes to the LDAP schema, which would mean new OID values.
I have the OID number assignment scheme written down on a scrap of paper
from years past ... I'll locate my notes and copy them here. There's an OID
space which was reserved for Guacamole ages ago (see 38971 within
https://www.iana.org/assignments/enterprise-numbers/enterprise-numbers), but
there is a system for consistently assigning numbers within that space.
---
