Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245756503
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java
---
@@ -167,18 +201,34 @@
// Parse name
String name = parameter.substring(0, equals);
String value = parameter.substring(equals+1);
-
- config.setParameter(name, value);
+
+ // Pull out and set proxy parameters, if
present
+ // Otherwise set the parameter.
+ switch(name) {
+ case PROXY_HOST_PARAMETER:
--- End diff --
Sounds good. I hesitated to modify the LDAP schema, but I'm happy to go
that route if that's the best way to go. Do you think separate LDAP attributes
specifically for proxying, or just a generic Guacamole Attribute that is
handled similar to the parameters?
For the OID, should we use the Guacamole one, or does ASF have one we
should go with?
---
