Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/353#discussion_r245747944
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java
---
@@ -148,12 +169,25 @@
// Set protocol
GuacamoleConfiguration config = new
GuacamoleConfiguration();
+
+ GuacamoleProxyConfiguration proxyConfig;
+ try {
+ proxyConfig = new
LocalEnvironment().getDefaultGuacamoleProxyConfiguration();
+ }
+ catch (GuacamoleException e) {
+ return null;
--- End diff --
If retrieval of the proxy config fails, that failure should be logged
rather than silently ignored.
---
