mike-jumper commented on a change in pull request #348: GUACAMOLE-422: Forward
Timezone to RDP and SSH Connections
URL: https://github.com/apache/guacamole-client/pull/348#discussion_r281049226
##########
File path:
guacamole/src/main/java/org/apache/guacamole/tunnel/TunnelRequest.java
##########
@@ -365,5 +370,16 @@ public Integer getDPI() throws GuacamoleException {
public List<String> getImageMimetypes() {
return getParameterValues(IMAGE_PARAMETER);
}
-
+
+ /**
+ * Returns the value of the timezone parameter declared within the
Review comment:
I suggest wording this from the perspective of the client and the semantics
behind the value returned, rather than the fact that it internally pulls the
"timezone" parameter.
For example, `getImageMimetypes()` is documented as returning the image
mimetypes that the client declares it supports:
https://github.com/apache/guacamole-client/blob/377e93c518fbee77fbfe04970d30d9b721bcaedf/guacamole/src/main/java/org/apache/guacamole/tunnel/TunnelRequest.java#L363-L364
and `getWidth()` is documented as returning the client's desired width:
https://github.com/apache/guacamole-client/blob/377e93c518fbee77fbfe04970d30d9b721bcaedf/guacamole/src/main/java/org/apache/guacamole/tunnel/TunnelRequest.java#L294-L295
If the above were documented instead as "the value of the width parameter"
or "the value of the image parameters", we would be missing information that is
important for the caller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
