mike-jumper commented on a change in pull request #348: GUACAMOLE-422: Forward
Timezone to RDP and SSH Connections
URL: https://github.com/apache/guacamole-client/pull/348#discussion_r281048928
##########
File path:
guacamole-common/src/main/java/org/apache/guacamole/protocol/ConfiguredGuacamoleSocket.java
##########
@@ -184,6 +199,20 @@ public ConfiguredGuacamoleSocket(GuacamoleSocket socket,
"image",
info.getImageMimetypes().toArray(new String[0])
));
+
+ // Protocol version 1.1.0 and higher options
+
+ if (protocol.atLeast(GuacamoleProtocolVersion.VERSION_1_1_0)) {
Review comment:
Thoughts on providing some sort of capability-style query rather than
requiring comparisons on version number? What you've got here will clearly work
fine for now, but will get cumbersome as new features are introduced.
Something like
`protocol.isSupported(GuacamoleProtocolCapability.HANDSHAKE_TIMEZONE)` would
remove the need for repeated version comparison logic here or elsewhere, and
would allow us to define what features are supported by what versions in a more
readable way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
