mike-jumper commented on a change in pull request #348: GUACAMOLE-422: Forward
Timezone to RDP and SSH Connections
URL: https://github.com/apache/guacamole-client/pull/348#discussion_r281047766
##########
File path:
guacamole-common/src/main/java/org/apache/guacamole/protocol/ConfiguredGuacamoleSocket.java
##########
@@ -184,6 +199,20 @@ public ConfiguredGuacamoleSocket(GuacamoleSocket socket,
"image",
info.getImageMimetypes().toArray(new String[0])
));
+
+ // Protocol version 1.1.0 and higher options
+
+ if (protocol.atLeast(GuacamoleProtocolVersion.VERSION_1_1_0)) {
+ // Send client timezone, if available
+ String timezone = info.getTimezone();
+ if (timezone != null && !timezone.isEmpty()) {
Review comment:
Any reason why both `null` and `""` are used rather than just `null`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
