mike-jumper commented on a change in pull request #348: GUACAMOLE-422: Forward
Timezone to RDP and SSH Connections
URL: https://github.com/apache/guacamole-client/pull/348#discussion_r281047898
##########
File path:
guacamole-common/src/main/java/org/apache/guacamole/protocol/GuacamoleClientInformation.java
##########
@@ -144,5 +149,25 @@ public void setOptimalResolution(int optimalResolution) {
public List<String> getImageMimetypes() {
return imageMimetypes;
}
+
+ /**
+ * Return the timezone as reported by the client.
+ *
+ * @return
+ * A string value of the timezone reported by the client.
Review comment:
If `null` and/or `""` have special meaning here, that meaning should be
documented for the sake of downstream users of this class. I would also suggest
settling on a single, specific representation for "no timezone" (presumably
`null`?).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
