necouchman commented on a change in pull request #454: GUACAMOLE-793: CAS
Provider returns Group - like LDAP Provider
URL: https://github.com/apache/guacamole-client/pull/454#discussion_r352386863
##########
File path:
extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/conf/ConfigurationService.java
##########
@@ -85,4 +85,34 @@ public PrivateKey getClearpassKey() throws
GuacamoleException {
return
environment.getProperty(CASGuacamoleProperties.CAS_CLEARPASS_KEY);
}
+ /**
+ * Returns the attribute used to determine group memberships
+ * in CAS, or null if not defined.
+ *
+ * @return
+ * The attribute name
+ *
+ * @throws GuacamoleException
+ * If guacamole.properties cannot be parsed.
+ */
+ public String getCasGroupAttribute() throws GuacamoleException {
+ return
environment.getProperty(CASGuacamoleProperties.CAS_GROUP_ATTRIBUTE);
+ }
+
+ /**
+ * Returns the attribute used to format group DN's
+ * in CAS, or null if not defined.
Review comment:
This seems a little unclear to me. I know you described the behavior in the
body of the pull request, so I think I get what you're trying to say, but try
to think of it from the perspective of someone reading JavaDocs without having
ever seen what you wrote on the pull request, and maybe without having read any
additional stuff that will be added to the manual. So, this should be a little
more descriptive of what the property is used for.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
