necouchman commented on a change in pull request #454: GUACAMOLE-793: CAS
Provider returns Group - like LDAP Provider
URL: https://github.com/apache/guacamole-client/pull/454#discussion_r352387217
##########
File path:
extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/user/CASAuthenticatedUser.java
##########
@@ -50,6 +51,12 @@
*/
private Map<String, String> tokens;
+ /**
+ * The unique identifiers of all user groups which affect the permissions
+ * available to this user.
Review comment:
I'm not sure that this should reference permissions, mainly because the CAS
module does not implement connections or permissions at all, so it may be a
little misleading to start referencing it within the context of this module.
While we do fully expect that these groups will be used to assign permissions
in other modules (JDBC), within this module it's simply the groups the user is
a member of.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
