necouchman commented on a change in pull request #454: GUACAMOLE-793: CAS
Provider returns Group - like LDAP Provider
URL: https://github.com/apache/guacamole-client/pull/454#discussion_r352386742
##########
File path:
extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/conf/ConfigurationService.java
##########
@@ -85,4 +85,34 @@ public PrivateKey getClearpassKey() throws
GuacamoleException {
return
environment.getProperty(CASGuacamoleProperties.CAS_CLEARPASS_KEY);
}
+ /**
+ * Returns the attribute used to determine group memberships
+ * in CAS, or null if not defined.
+ *
+ * @return
+ * The attribute name
Review comment:
This should probably be more along the lines of "The attribute name used to
determine group memberships in CAS, or null if not defined." I know it seems
redundant based on what's already a couple of lines above it, but when people
are looking at the JavaDoc documentation for a Guacamole method there are
situations where it can be useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
