mike-jumper opened a new pull request #243: GUACAMOLE-249: Migrate to FreeRDP 2.x URL: https://github.com/apache/guacamole-server/pull/243 This change refactors the entirety of Guacamole's RDP support to use FreeRDP 2.x, removing any remaining compatibility with older FreeRDP releases. These changes also: * Reorganize the source tree in the hopes of making things more maintainable going forward * Add missing documentation * Add support for the new "extended NLA" mode added by FreeRDP 2.x (I'm not entirely sure what this is, however) and switch over to "any" as the default security method (rather than "rdp"). * Remove most plugins, replacing guacsvc/guacsnd/guacdr with a single common SVC plugin. The RDP support leverages that common plugin to provide a single API which the arbitrary SVC, RDPSND, and RDPDR support then use without having to make plugins for each. There are going to be conflicts with master for the following non-1.1.0 changes: * [GUACAMOLE-296](https://issues.apache.org/jira/browse/GUACAMOLE-296) - Migrating to FreeRDP 2.x removes the need for this, as libwinpr is now automatically linked using pkgconfig. * [GUACAMOLE-381](https://issues.apache.org/jira/browse/GUACAMOLE-381) - Support for clipboard copy/paste disable flags within CLIPRDR need to be manually re-added due to the number of changes made to CLIPRDR (see below). Much of this applies cleanly without conflict. * [GUACAMOLE-764](https://issues.apache.org/jira/browse/GUACAMOLE-764) - Most applied cleanly without conflict, however one `int` -> `uint64_t` change has to be reapplied manually (see below). * [GUACAMOLE-847](https://issues.apache.org/jira/browse/GUACAMOLE-847) - The RDPSND memory leak is now inherently resolved via the common SVC plugin and changes to channel memory handling in FreeRDP 2.x. To hopefully ease this, I've performed a test merge and manually resolved the above conflicts. I recommend resolving conflicts such that things match: https://github.com/mike-jumper/guacamole-server/tree/freerdp-migrate-2.x-resolve-merge-master ... Good luck.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
