mike-jumper commented on issue #243: GUACAMOLE-249: Migrate to FreeRDP 2.x URL: https://github.com/apache/guacamole-server/pull/243#issuecomment-571334143 OK - the only remaining things I managed to find are: * Pointer `SetNull` and `SetDefault` implementations were stubs. Don't know how long this has been the case, but since it's essentially one line to add these, I have done so. * I had manually set the `ReceiveChannelData` handler to `freerdp_channels_data()`, but this is the default and need not be manually set. I've now removed that line. * There was a potential segfault if the connection ends early enough that any of the various SVCs didn't actually connect before their termination handlers were invoked, as a couple of those implementations did not check whether they had actually allocated their internal structures before attempting to free them. Fixed this with commit 67c5bdf. * Security negotiation would fail apparently due to having the "extended mode" of NLA enabled by default. Checking the FreeRDP source, they do not do this, and disabling "extended mode" by default fixes things. * The new default of "any" for security mode is more convenient given that NLA is the new normal for RDP, but this breaks past usage where users may be relying on the lack of username/password to result in a traditional Windows login prompt. I've modified "any" such that it will not attempt to negotiate NLA if doing so would be impossible due to the lack of username/password (at least until parameter prompting is in there).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
