mike-jumper commented on issue #243: GUACAMOLE-249: Migrate to FreeRDP 2.x URL: https://github.com/apache/guacamole-server/pull/243#issuecomment-571311358 After some self review, I've added a few more commits: * The color conversion function behaved incorrectly due to `FreeRDPConvertColor()` expecting the input color to be coming from `ReadColor()`. `ReadColor()` converts a color which is independent of native endianness to an intermediate format which is dependent on native endianness, and `FreeRDPConvertColor()` will only work correctly with that intermediate format. This was causing an issue where black text was occasionally rendering as bright blue, with the bright blue coming from the 0xFF value for the alpha channel being stuck in the wrong place. (See commit a54a123) * I had previously modified the common surface implementation to avoid automatically flushing the surface when a rectangle is drawn (typically used for initializing the surface) when that surface hasn't yet been sent to the client (common for RDP, where we sometimes receive instructions to create an off-screen surface and then destroy it without ever actually using it). The logic wasn't entirely correct, and accidentally removed some consideration of the dirty flag when determining whether to combine updates. (See commit 0677a9a) * I ran the Include What You Use tool before opening this PR to try to clean up the headers included over the ages, as many no longer need to be included in those locations due to changes made. That tool added empty `struct` forward declarations which were unnecessary. I have removed these. (See commit 1f24c47) I didn't redo the test merge on https://github.com/mike-jumper/guacamole-server/tree/freerdp-migrate-2.x-resolve-merge-master, but I did at least cherry pick the above commits onto that branch so the contents will match the expected merge resolution.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
