mike-jumper opened a new pull request #245: GUACAMOLE-249: Automatically determine correct location for FreeRDP plugins. URL: https://github.com/apache/guacamole-server/pull/245 This change leverages pkg-config to determine the actual, correct location used by FreeRDP for its plugins, logging the discovered directory in the summary at the end of `configure` and using that directory for the install location of the FreeRDP plugins (regardless of any prefix, libdir, etc. that might otherwise have been given as options to the `configure` script): ``` [mjumper@dev-mjumper guacamole-server]$ ./configure ... config.status: creating config.h config.status: executing depfiles commands config.status: executing libtool commands ------------------------------------------------ guacamole-server version 1.1.0 ------------------------------------------------ Library status: freerdp2 ............ yes pango ............... yes libavcodec .......... yes libavutil ........... yes libssh2 ............. yes libssl .............. yes libswscale .......... yes libtelnet ........... yes libVNCServer ........ yes libvorbis ........... yes libpulse ............ yes libwebsockets ....... yes libwebp ............. yes wsock32 ............. no Protocol support: Kubernetes .... yes RDP ........... yes SSH ........... yes Telnet ........ yes VNC ........... yes Services / tools: guacd ...... yes guacenc .... yes guaclog .... yes FreeRDP plugins: /usr/lib64/freerdp2 Init scripts: no Systemd units: no Type "make" to compile guacamole-server. [mjumper@dev-mjumper guacamole-server]$ ``` I figured this might be worth doing as part of GUACAMOLE-249, given that the FreeRDP plugins being installed are changing and symbolic links from installs of Apache Guacamole 1.0.0 and older will not work. If others think this should be a separate issue, I'm not extremely against letting this wait, but I think this will save everyone some pain.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
