mike-jumper commented on a change in pull request #245: GUACAMOLE-249: 
Automatically determine correct location for FreeRDP plugins.
URL: https://github.com/apache/guacamole-server/pull/245#discussion_r367620830
 
 

 ##########
 File path: configure.ac
 ##########
 @@ -994,6 +996,12 @@ AM_COND_IF([ENABLE_INIT], [build_init="${init_dir}"], 
[build_init=no])
 
 AM_COND_IF([ENABLE_SYSTEMD], [build_systemd="${systemd_dir}"], 
[build_systemd=no])
 
+#
+# FreeRDP plugins
+#
+
+AM_COND_IF([ENABLE_RDP], [build_rdp_plugins="${FREERDP2_PLUGIN_DIR}"], 
[build_rdp_plugins=no])
 
 Review comment:
   OK, I've added a `--with-freerdp-plugin-dir` option. From `./configure 
--help`:
   
   ```
   ...
     --with-terminal         support text-based protocols [default=check]
     --with-vnc              support VNC [default=check]
     --with-rdp              support RDP [default=check]
     --with-freerdp-plugin-dir=<path>
                             install FreeRDP plugins to the given directory
                             [default=check]
   ...
   ```
   
   If given, the value will be used instead of attempting to derive the value 
from the package lib directory exposed by pkg-config.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to