mike-jumper commented on a change in pull request #245: GUACAMOLE-249:
Automatically determine correct location for FreeRDP plugins.
URL: https://github.com/apache/guacamole-server/pull/245#discussion_r367614387
##########
File path: configure.ac
##########
@@ -994,6 +996,12 @@ AM_COND_IF([ENABLE_INIT], [build_init="${init_dir}"],
[build_init=no])
AM_COND_IF([ENABLE_SYSTEMD], [build_systemd="${systemd_dir}"],
[build_systemd=no])
+#
+# FreeRDP plugins
+#
+
+AM_COND_IF([ENABLE_RDP], [build_rdp_plugins="${FREERDP2_PLUGIN_DIR}"],
[build_rdp_plugins=no])
Review comment:
It depends on which variable you're referring to:
The `build_rdp_plugins` variable is only used to represent the status of the
build visually within the summary. If it ends up being "no" (due to FreeRDP
being absent or due to RDP being explicitly disabled via command line options
passed to `configure`), then the summary ends up looking like:
```
...
Services / tools:
guacd ...... yes
guacenc .... yes
guaclog .... yes
FreeRDP plugins: no
Init scripts: no
Systemd units: no
...
```
`FREERDP2_PLUGIN_DIR` cannot be "no". It could potentially be a strange
value if the pkg-config file installed by FreeRDP is broken, in which case the
RDP part of the build would be broken.
I'll add a `--with-freerdp-plugin-dir` option to override the auto-detected
value, in case the detected value ends up being incorrect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
