mike-jumper commented on a change in pull request #454: GUACAMOLE-793: CAS
Provider returns Group - like LDAP Provider
URL: https://github.com/apache/guacamole-client/pull/454#discussion_r383642551
##########
File path:
extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/ticket/TicketValidationService.java
##########
@@ -122,15 +127,41 @@
}
// Convert remaining attributes that have values to Strings
+ String groupAttribute = confService.getCasGroupAttribute();
+ // Use cas-member-attribute to retrieve and set group memberships
+ String groupDnFormat = confService.getCasGroupDnFormat();
+ String groupTemplate = "";
+ if (groupDnFormat != null) {
+ // if CAS is backended to LDAP, groups come in as RFC4514 DN
+ // syntax. If cas-group-dn-format is set, this strips
+ // an entry such as "CN=Foo,OU=Bar,DC=example,DC=com" to
+ // "Foo"
+ groupTemplate =
groupDnFormat.replace("%s","([A-Za-z0-9_\\(\\)\\-\\.\\s+]+)");
+ // the underlying parser aggregates all instances of the same
+ // attribute, so we need to be able to parse them out
+ groupTemplate=groupTemplate+",*\\s*";
+ } else {
+ groupTemplate = "([A-Za-z0-9_\\(\\)\\-\\.\\s+]+,*\\s*)";
Review comment:
The `getProperty()` function already has a variant for providing a default
value. There's no need to test for `null` and manually select that default.
I'd also suggest that even if there were such a need, it would be better to
abstract that within the relevant function within `ConfigurationService`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
