mike-jumper commented on a change in pull request #454: GUACAMOLE-793: CAS
Provider returns Group - like LDAP Provider
URL: https://github.com/apache/guacamole-client/pull/454#discussion_r383641807
##########
File path:
extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/conf/CASGuacamoleProperties.java
##########
@@ -68,5 +69,30 @@ private CASGuacamoleProperties() {}
public String getName() { return "cas-clearpass-key"; }
};
+
+ /**
+ * The attribute used for group membership
+ * example: memberOf (case sensitive)
+ */
+ public static final StringGuacamoleProperty CAS_GROUP_ATTRIBUTE =
+ new StringGuacamoleProperty() {
+ @Override
+ public String getName() { return "cas-group-attribute"; }
+
+ };
+
+ /**
+ * The attribute used for group DN Format
+ * such as CN=%s,OU=myou,DC=example,DC=com (case sensitive)
+ * used to strip all but %s. This is only necessary when
+ * CAS backend is LDAP.
+ */
Review comment:
Are there other cases where CAS might have group names in a specific format?
If so, perhaps this should be more generic and not specific to an LDAP DN?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
