mike-jumper commented on a change in pull request #454: GUACAMOLE-793: CAS Provider returns Group - like LDAP Provider URL: https://github.com/apache/guacamole-client/pull/454#discussion_r383643809
########## File path: extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/util/TokensAndGroups.java ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.guacamole.auth.cas.util; + +import java.util.HashMap; +import java.util.Map; +import java.util.Set; +import java.util.HashSet; + + /** + * A class to facilitate the return values of both Tokens and Groups Review comment: There should be a better way to achieve this (more on this above). I don't think we should be declaring a class just to be a type-specific pair when there is no other high-level concept behind that class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
