mike-jumper commented on a change in pull request #312:
URL: https://github.com/apache/guacamole-server/pull/312#discussion_r518993125
##########
File path: src/protocols/rdp/channels/audio-input/audio-buffer.h
##########
@@ -66,6 +66,27 @@ typedef struct guac_rdp_audio_format {
} guac_rdp_audio_format;
+/**
+ * A structure of list to take the audio buffers.
+ */
+typedef struct audio_stream_list {
+ /**
+ * The data of audio buffer
+ */
+ char* data;
+
+ /**
+ * The length of audio buffer
+ */
+ int length;
+
+ /**
+ * The pointer of the next audio buffer
+ */
+ void* next;
Review comment:
This should be a pointer to a concrete type, presumably
`audio_stream_list` (which would then need a forward declaration). We should
only be using `void*` for pointers that truly are intended to point to
arbitrary data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
