mike-jumper commented on a change in pull request #312:
URL: https://github.com/apache/guacamole-server/pull/312#discussion_r519088659
##########
File path: src/protocols/rdp/client.h
##########
@@ -87,6 +87,11 @@
*/
#define GUAC_RDP_AUDIO_BPS 16
+/**
+ * Interval to send the audio input packet to a remote server, in ms.
+ */
+#define GUAC_RDP_AUDIO_INPUT_SEND_INTERVAL 5
Review comment:
Rather than specify an arbitrary static value, perhaps the interval
should be derived from the number of audio frames that the RDP server dictates
should be sent in each PDU?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
