myjimmy commented on a change in pull request #312:
URL: https://github.com/apache/guacamole-server/pull/312#discussion_r532774544
##########
File path: src/protocols/rdp/channels/audio-input/audio-buffer.c
##########
@@ -131,6 +137,19 @@ void guac_rdp_audio_buffer_begin(guac_rdp_audio_buffer*
audio_buffer,
* audio_buffer->out_format.channels
* audio_buffer->out_format.bps;
+ /* Calculate the interval to send each packet in ms.
+ * We need to set half of the time duration designated
+ * by packet frames according to Nyquist's theorem.
+ */
+ audio_buffer->packet_interval = packet_frames
+ * 1000
+ / audio_buffer->out_format.rate
+ / 2;
Review comment:
Because the time interval of sending audio packets isn't even and the
time interval occasionally exceeds one packet length, the choppy issue
occurred.
So, I think that we need to make sure that the intervals will at least be
one half of one packet length.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
