benrubson commented on a change in pull request #314:
URL: https://github.com/apache/guacamole-server/pull/314#discussion_r537371282
##########
File path: Dockerfile
##########
@@ -115,7 +115,8 @@ HEALTHCHECK --interval=5m --timeout=5s CMD nc -z 127.0.0.1
4822 || exit 1
# Create a new user guacd
ARG UID=1000
-RUN useradd --system --create-home --shell /usr/sbin/nologin --uid $UID
--no-user-group guacd
+RUN groupadd --gid $UID guacd
+RUN useradd --system --create-home --shell /usr/sbin/nologin --uid $UID --gid
$UID guacd
Review comment:
Note that there's no risk for both `UID` and `GID` to have the same
numerical value (`1000` here).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
