benrubson commented on a change in pull request #314:
URL: https://github.com/apache/guacamole-server/pull/314#discussion_r537395392
##########
File path: Dockerfile
##########
@@ -115,7 +115,8 @@ HEALTHCHECK --interval=5m --timeout=5s CMD nc -z 127.0.0.1
4822 || exit 1
# Create a new user guacd
ARG UID=1000
-RUN useradd --system --create-home --shell /usr/sbin/nologin --uid $UID
--no-user-group guacd
+RUN groupadd --gid $UID guacd
+RUN useradd --system --create-home --shell /usr/sbin/nologin --uid $UID --gid
$UID guacd
Review comment:
OK, both UID and GID with a `1000` value are free for use in the image
(the free range around 1000 is rather large).
And both are now identified with their own `ARG`.
Should then be OK, or did I perhaps miss something ?
Thank you again 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
