mike-jumper commented on a change in pull request #314:
URL: https://github.com/apache/guacamole-server/pull/314#discussion_r537382418
##########
File path: Dockerfile
##########
@@ -115,7 +115,8 @@ HEALTHCHECK --interval=5m --timeout=5s CMD nc -z 127.0.0.1
4822 || exit 1
# Create a new user guacd
ARG UID=1000
-RUN useradd --system --create-home --shell /usr/sbin/nologin --uid $UID
--no-user-group guacd
+RUN groupadd --gid $UID guacd
+RUN useradd --system --create-home --shell /usr/sbin/nologin --uid $UID --gid
$UID guacd
Review comment:
Well ... there is no risk if they _happen_ to have the same value, or if
the same value is intentionally chosen for both the UID and the GID after that
value was been confirmed to be available within both UID and GID pools.
The important thing is to not have the image build written to directly use a
UID as if it were a GID.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
