mike-jumper opened a new pull request #600: URL: https://github.com/apache/guacamole-client/pull/600
Since migrating to Jersey 2.x, a mismatch between Jackson versions has resulted in some Jackson annotations being ignored. This is due to a difference in package name between the Jackson versions. From the perspective of the newer Jackson, the classes with the older annotations are simply unannotated. This change updates the annotations where needed, and removes use of those annotations in extensions that should not make any assumptions regarding the JSON serialization implementation. But wait! What about:  With the core issue here being a version mismatch for a common dependency, part of the resolution had to be updating dependencies to use the same common versions. This resulted in a refactor of all `pom.xml` files to leverage a common, shared set of dependencies. But wait! That still doesn't quite account for:  With a great many dependencies having to be updated, the various referenced licenses needed to be updated, as well. This includes the numerous copies of the "guice-3.0" dependency and license. Rather than manually update each of these, I instead: 1. Created a script and build process for automatically generating `LICENSE` and `NOTICE` based on actual runtime dependencies as reported by Maven. 2. Removed duplicated references to the Apache License, which we really only need one of. 3. Added licenses for dependencies that were missing license documentation. 4. Added/updated `NOTICE` files where information was missing. From here on, the amount of duplicated `pom.xml` content is reduced, updating license information should be much easier, and the build will outright fail if we are missing license info. It also should fix the issue reported on the mailing list regarding TOTP no longer presenting a QR code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
