mike-jumper commented on a change in pull request #600:
URL: https://github.com/apache/guacamole-client/pull/600#discussion_r605887739
##########
File path: extensions/.ratignore
##########
@@ -0,0 +1 @@
+guacamole-auth-radius/**/*
Review comment:
It's checked when it's built by the RAT plugin (it will automatically
run when the build is triggered for all projects now, including
guacamole-auth-radius).
The issue here is that guacamole-auth-radius is not part of the build unless
explicitly included with `-Plgpl-extensions`. The RAT plugin will helpfully
exclude modules from the check, but that exclusion won't occur for
guacamole-auth-radius if it's not part of the current build. This forces that
module to be ignored regardless of whether it's part of the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
