necouchman commented on a change in pull request #600:
URL: https://github.com/apache/guacamole-client/pull/600#discussion_r605883738
##########
File path:
extensions/guacamole-auth-duo/src/main/java/org/apache/guacamole/auth/duo/form/DuoSignedResponseField.java
##########
@@ -81,8 +80,7 @@ public DuoSignedResponseField(String apiHost, String
signedRequest) {
* @return
* The hostname of the DuoWeb API endpoint.
*/
- @JsonProperty("apiHost")
- public String getAPIHost() {
+ public String getApiHost() {
Review comment:
I see this changed, here, to a more strict CamelCase, along with a
couple of others like it in other places in the code, but I don't see that any
of the calls to this method get changed. Am I missing something?
##########
File path: extensions/.ratignore
##########
@@ -0,0 +1 @@
+guacamole-auth-radius/**/*
Review comment:
So does the RADIUS extension not get checked at all? It is excluded,
here, and the RAT stuff is also removed from the RADIUS extension's pom.xml
file. Does the fact that it's got (L)GPL dependencies mean that we don't do any
checking on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
