mike-jumper opened a new pull request #698:
URL: https://github.com/apache/guacamole-client/pull/698
This change adds API representation of logs and recordings at the history
entry level, and allows those resources to be retrieved from history entries
via the REST API.
This is achieved by:
1. Adding a deterministic (and optional) UUID for history entries with
semantics that allow the UUID to be known prior to the connection being fully
established, as well as an optional identifier that allows individual history
entries to be retrieved directly.
2. Adding a `${HISTORY_UUID}` token that allows recordings, etc. to be saved
and later reassociated with the history entries that correspond to the
connections that created those recordings.
3. Adding an extension, "guacamole-history-recording-storage", which
automatically searches a defined path (`/var/lib/guacamole/recordings/` by
default) for files matching history entry UUIDs. If any are found, their type
is identified and the file is associated with the history entry via decoration.
Thus, history entries and recordings may be tied together without requiring
database schema changes.
Users are only able to retrieve recordings/logs for a history entry if they
have access to that history entry. It's up to the implementation to define
whether users may view history entries, however the database restricts this to
only users that can view both the relevant connection and relevant user. The
storage extension implemented here additionally requires that a user have
`UPDATE` permission on the associated connection to be able to retrieve a
history entry, as it seems sensible to limit access to logs/recordings to only
those that manage the connection. It might make sense for this to be
configurable in the future.
(Creating as draft, as SQL queries for directly retrieving history entries
need to be added, rather than relying on the default search behavior).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
