mike-jumper commented on a change in pull request #698:
URL: https://github.com/apache/guacamole-client/pull/698#discussion_r806084940
##########
File path:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection/ConnectionRecordMapper.java
##########
@@ -19,113 +19,9 @@
package org.apache.guacamole.auth.jdbc.connection;
-import java.util.Collection;
-import java.util.List;
-import org.apache.guacamole.auth.jdbc.base.ActivityRecordSearchTerm;
-import org.apache.guacamole.auth.jdbc.base.ActivityRecordSortPredicate;
-import org.apache.ibatis.annotations.Param;
-import org.apache.guacamole.auth.jdbc.user.UserModel;
+import org.apache.guacamole.auth.jdbc.base.ActivityRecordMapper;
/**
* Mapper for connection record objects.
*/
-public interface ConnectionRecordMapper {
-
- /**
- * Returns a collection of all connection records associated with the
- * connection having the given identifier.
- *
- * @param identifier
- * The identifier of the connection whose records are to be retrieved.
- *
- * @return
- * A collection of all connection records associated with the
- * connection having the given identifier. This collection will be
- * empty if no such connection exists.
- */
- List<ConnectionRecordModel> select(@Param("identifier") String identifier);
-
- /**
- * Inserts the given connection record.
- *
- * @param record
- * The connection record to insert.
- *
- * @return
- * The number of rows inserted.
- */
- int insert(@Param("record") ConnectionRecordModel record);
-
- /**
- * Searches for up to <code>limit</code> connection records that contain
- * the given terms, sorted by the given predicates, regardless of whether
- * the data they are associated with is is readable by any particular user.
- * This should only be called on behalf of a system administrator. If
- * records are needed by a non-administrative user who must have explicit
- * read rights, use {@link searchReadable()} instead.
- *
- * @param identifier
- * The optional connection identifier to which records should be
limited,
- * or null if all records should be retrieved.
- *
- * @param terms
- * The search terms that must match the returned records.
- *
- * @param sortPredicates
- * A list of predicates to sort the returned records by, in order of
- * priority.
- *
- * @param limit
- * The maximum number of records that should be returned.
- *
- * @return
- * The results of the search performed with the given parameters.
- */
- List<ConnectionRecordModel> search(@Param("identifier") String identifier,
- @Param("terms") Collection<ActivityRecordSearchTerm> terms,
- @Param("sortPredicates") List<ActivityRecordSortPredicate>
sortPredicates,
- @Param("limit") int limit);
-
- /**
- * Searches for up to <code>limit</code> connection records that contain
- * the given terms, sorted by the given predicates. Only records that are
- * associated with data explicitly readable by the given user will be
- * returned. If records are needed by a system administrator (who, by
- * definition, does not need explicit read rights), use {@link search()}
- * instead.
- *
- * @param identifier
- * The optional connection identifier for which records should be
- * retrieved, or null if all readable records should be retrieved.
- *
- * @param user
- * The user whose permissions should determine whether a record is
- * returned.
- *
- * @param terms
- * The search terms that must match the returned records.
- *
- * @param sortPredicates
- * A list of predicates to sort the returned records by, in order of
- * priority.
- *
- * @param limit
- * The maximum number of records that should be returned.
- *
- * @param effectiveGroups
- * The identifiers of all groups that should be taken into account
- * when determining the permissions effectively granted to the user. If
- * no groups are given, only permissions directly granted to the user
- * will be used.
- *
- * @return
- * The results of the search performed with the given parameters.
- */
- List<ConnectionRecordModel> searchReadable(@Param("identifier") String
identifier,
- @Param("user") UserModel user,
- @Param("terms") Collection<ActivityRecordSearchTerm> terms,
- @Param("sortPredicates") List<ActivityRecordSortPredicate>
sortPredicates,
- @Param("limit") int limit,
- @Param("effectiveGroups") Collection<String> effectiveGroups);
-
-}
+public interface ConnectionRecordMapper extends
ActivityRecordMapper<ConnectionRecordModel> {}
Review comment:
There would be no downstream impact as it's not a part of the public API
(these mappers are internal pieces of the database auth implementation). I
don't think we can remove it, though, as MyBatis needs to be able to determine
with XML mapping file corresponds to which mapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
