mike-jumper commented on a change in pull request #698:
URL: https://github.com/apache/guacamole-client/pull/698#discussion_r806091761
##########
File path:
guacamole/src/main/java/org/apache/guacamole/rest/history/APIActivityRecord.java
##########
@@ -55,6 +58,30 @@
*/
private final boolean active;
+ /**
+ * The unique identifier assigned to this record, or null if this record
+ * has no such identifier.
+ */
+ private final String identifier;
+
+ /**
+ * A UUID uniquely identifies this record, or null if no such unique
Review comment:
Oops - I'll add that "that".
I think "uniquely identifies" should remain, as it is specifically this
record that is uniquely identified. The value _should_ be unique relative to
all possible UUIDs, but the specification for the record UUIDs given by
`getUUID()` of `ActivityRecord` allows some wiggle room here so long as it's at
least unique relative to other records in the same set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
