mike-jumper commented on code in PR #383:
URL: https://github.com/apache/guacamole-server/pull/383#discussion_r894792295
##########
src/terminal/terminal.c:
##########
@@ -335,6 +335,67 @@ guac_terminal_options* guac_terminal_options_create(
return options;
}
+/**
+ * Calculate the available space within the terminal
+ * and store the results in the pointer arguments.
+ *
+ * @param terminal
+ * The terminal provides character width and height for calculations.
+ *
+ * @param width
+ * The width of the terminal, in pixels.
+ *
+ * @param height
+ * The height of the terminal, in pixels.
+ *
+ * @param aw
+ * Set with the available width for text of the terminal, in pixels.
+ *
+ * @param ah
+ * Set with the available height for text of the terminal, in pixels.
+ *
+ * @param columns
+ * Set with the available width for text of the terminal, by column count.
+ *
+ * @param rows
+ * Set with the available height for text of the terminal, by row count.
+ */
+static void get_available_dimensions(guac_terminal* term, int width, int
height,
+ int* aw, int* ah, int* columns, int* rows) {
Review Comment:
Is there any case where this would not be used to calculate available
dimensions from `outer_width` and `outer_height`, and is there any case where
this is not ultimately used to assign the resulting values back to the
`guac_terminal`?
If not, perhaps this would be better as `set_available_dimensions(term,
width, height)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
