jmuehlner commented on code in PR #383:
URL: https://github.com/apache/guacamole-server/pull/383#discussion_r896020901
##########
src/terminal/terminal.c:
##########
@@ -335,6 +335,67 @@ guac_terminal_options* guac_terminal_options_create(
return options;
}
+/**
+ * Calculate the available space within the terminal
+ * and store the results in the pointer arguments.
+ *
+ * @param terminal
+ * The terminal provides character width and height for calculations.
+ *
+ * @param width
+ * The width of the terminal, in pixels.
+ *
+ * @param height
+ * The height of the terminal, in pixels.
+ *
+ * @param aw
+ * Set with the available width for text of the terminal, in pixels.
+ *
+ * @param ah
+ * Set with the available height for text of the terminal, in pixels.
+ *
+ * @param columns
+ * Set with the available width for text of the terminal, by column count.
+ *
+ * @param rows
+ * Set with the available height for text of the terminal, by row count.
+ */
+static void get_available_dimensions(guac_terminal* term, int width, int
height,
+ int* aw, int* ah, int* columns, int* rows) {
Review Comment:
I see that there is special handling for `columns` and `rows` for resizes,
but in both cases where `get_available_dimensions` is called, the next thing
that's done is setting the terminal height and width using `aw` and `ah`.
Why not skip setting the pointers and just set those directly on the
terminal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
