jmuehlner commented on code in PR #383:
URL: https://github.com/apache/guacamole-server/pull/383#discussion_r896017364
##########
src/terminal/terminal.c:
##########
@@ -335,6 +335,68 @@ guac_terminal_options* guac_terminal_options_create(
return options;
}
+/**
+ * Calculate the available space within the terminal
+ * and store the results in the pointer arguments.
+ *
+ * @param terminal
+ * The terminal provides character width and height for calculations.
+ * This function requires outer_width, outer_height,
+ * display->margin, display->char_height, and display->char_width
+ * to be set on terminal in order to calculate available dimensions.
+ *
+ * @param aw
+ * Set with the available width for text of the terminal, in pixels.
+ *
+ * @param ah
+ * Set with the available height for text of the terminal, in pixels.
+ *
+ * @param columns
+ * Set with the available width for text of the terminal, by column count.
+ *
+ * @param rows
+ * Set with the available height for text of the terminal, by row count.
+ */
+static void get_available_dimensions(guac_terminal* term,
Review Comment:
At this point, having the function called `get_...` is pretty misleading -
usually you'd expect a getter to return a value, which this doesn't do.
Maybe `calculate_and_save_...` or similar might be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
