jmuehlner commented on code in PR #796:
URL: https://github.com/apache/guacamole-client/pull/796#discussion_r1117489112
##########
guacamole/src/main/frontend/src/app/clipboard/directives/guacClipboard.js:
##########
@@ -92,17 +141,23 @@ angular.module('clipboard').directive('guacClipboard',
['$injector',
// that indicate the clipboard field may have been changed
element.addEventListener('input', updateClipboardData);
element.addEventListener('change', updateClipboardData);
+ element.addEventListener('focus', displayAndUpdateClipboardEditor);
+ element.addEventListener('blur', hideAndUpdateClipboardEditor);
Review Comment:
Do we really want to hide the contents of the clipboard every time it's
blurred? That would get pretty annoying. I'd think that just initially hiding
the clipboard every time the sidebar is opened and re-hiding when the sidebar
is closed should be good enough.
I'd welcome other opinions on this, however.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
