necouchman commented on PR #945: URL: https://github.com/apache/guacamole-client/pull/945#issuecomment-1895651428
@myjimmy I have some concerns with these changes... * It's unclear to me _why_ removing the `pushSelection()` and `popSelection()` calls fixes the issue described in the Jira ticket? From that, it sounds like this is only an issue on insecure (HTTP://) connections, and others work fine. Why is this particular change necessary to solve that issue? * Based on the comments around the changes, it seems like the blur was intentionally added for mobile browsers - is it really the push/pop that needs to be removed, or does the blur need to be handled differently (maybe only on mobile browsers)? * Do these changes have any other impacts to other platforms - particularly the mobile ones mentioned in the comments around this section? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
