myjimmy commented on PR #945: URL: https://github.com/apache/guacamole-client/pull/945#issuecomment-1896452790
> It's unclear to me why removing the pushSelection() and popSelection() calls fixes the issue described in the Jira ticket? From that, it sounds like this is only an issue on insecure (HTTP://) connections, and others work fine. Why is this particular change necessary to solve that issue? @necouchman The Asynchronous Clipboard API is available only but in secure contexts (HTTPS) also in some of browsers. https://developer.mozilla.org/en-US/docs/Web/API/Clipboard#browser_compatibility > Based on the comments around the changes, it seems like the blur was intentionally added for mobile browsers - is it really the push/pop that needs to be removed, or does the blur need to be handled differently (maybe only on mobile browsers)? Because the removed code is related to only the clipboard of the non-text content, it have no relation to the blur() and focus() functions. The blur() and focus() functions are called for performing the deprecated clipboard command. > Do these changes have any other impacts to other platforms - particularly the mobile ones mentioned in the comments around this section? I think that these changes have no impacts to other platforms. I've tested my fix on some kinds of mobile devices (iphone, android) and browsers (firefox, chrome, safari). It works well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
