mike-jumper commented on PR #945: URL: https://github.com/apache/guacamole-client/pull/945#issuecomment-1896612030
The `pushSelection()` and `popSelection()` functions are not specific to support for images - they prevent the current selection state within the browser from being clobbered by the call to `selectAll()` that has to occur before we invoke `document.execCommand()`. From the description of GUACAMOLE-1678 and the nature of these changes, it sounds like manipulating the selection state is having unintended side effects, but I'm skeptical that simply removing `pushSelection()`, etc. is correct. I would be concerned that this introduces other strange selection behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
