jmuehlner commented on code in PR #902:
URL: https://github.com/apache/guacamole-client/pull/902#discussion_r1759170002
##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/JDBCEnvironment.java:
##########
@@ -271,5 +278,24 @@ public boolean shouldUseBatchExecutor() {
return true;
}
+
+ /**
+ * Returns a boolean value that indicates whether or not usernames should
+ * be treated as case-sensitive.
+ *
+ * @return
+ * true if usernames should be treated as case-sensitive, or false if
+ * usernames should be treated as case-insensitive.
+ *
+ * @throws GuacamoleException
+ * If guacamole.properties cannot be parsed.
+ */
+ public boolean getCaseSensitiveUsernames() throws GuacamoleException {
+
+ LOGGER.warn("This database extension does not support case-sensitive
username comparisons.");
Review Comment:
I wonder if we could only warn when the webapp is configured to use
case-sensitive username comparisons.
It's not clear that it's particularly useful to warn admins about something
that they're not even trying to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
