jmuehlner commented on code in PR #966:
URL: https://github.com/apache/guacamole-client/pull/966#discussion_r1550641716
##########
extensions/guacamole-auth-duo/src/main/java/org/apache/guacamole/auth/duo/UserVerificationService.java:
##########
@@ -75,39 +97,72 @@ public void verifyAuthenticatedUser(AuthenticatedUser
authenticatedUser)
// Ignore anonymous users
if
(authenticatedUser.getIdentifier().equals(AuthenticatedUser.ANONYMOUS_IDENTIFIER))
return;
-
- // Retrieve signed Duo response from request
- String signedResponse =
request.getParameter(DuoSignedResponseField.PARAMETER_NAME);
-
- // If no signed response, request one
- if (signedResponse == null) {
-
- // Create field which requests a signed response from Duo that
- // verifies the identity of the given user via the configured
- // Duo API endpoint
- Field signedResponseField = new DuoSignedResponseField(
- confService.getAPIHostname(),
- duoService.createSignedRequest(authenticatedUser));
-
- // Create an overall description of the additional credentials
- // required to verify identity
- CredentialsInfo expectedCredentials = new CredentialsInfo(
- Collections.singletonList(signedResponseField));
+
+ String username = authenticatedUser.getIdentifier();
+
+ try {
+
+ String redirectUrl = confService.getRedirectUrl().toString();
Review Comment:
It looks like this whole block is missing a level of indentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
