jmuehlner commented on code in PR #966: URL: https://github.com/apache/guacamole-client/pull/966#discussion_r1550652174
########## guacamole-ext/src/main/java/org/apache/guacamole/net/auth/credentials/GuacamoleInsufficientCredentialsException.java: ########## @@ -28,6 +28,95 @@ */ public class GuacamoleInsufficientCredentialsException extends GuacamoleCredentialsException { +/** + * The default state token to use when no specific state information is provided. + */ +private static final String DEFAULT_STATE = ""; + +/** + * The default provider identifier to use when no specific provider is identified. + * This serves as a placeholder indicating that either no specific provider is + * responsible for the exception or the responsible provider has not been identified. + */ +private static final String DEFAULT_PROVIDER_IDENTIFIER = ""; + +/** + * The default query identifier to use when no specific query is identified. + * This serves as a placeholder and indicates that the specific query related to + * the provider's state resume operation has not been provided. + */ +private static final String DEFAULT_QUERY_IDENTIFIER = ""; + +/** + * The default expiration timestamp to use when no specific expiration is provided, + * effectively indicating that the state token does not expire. + */ +private static final long DEFAULT_EXPIRES = -1L; + +/** + * An opaque value that may be used by a client to maintain state across requests + * which are part of the same authentication transaction. + */ +protected final String state; + + /** + * The identifier for the authentication provider that threw this exception. + * This is used to link the exception back to the originating source of the + * authentication attempt, allowing clients to determine which provider's + * authentication process should be resumed. + */ + protected final String providerIdentifier; Review Comment: These fields look overindented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org